From 2b1af9d27cb6585ce223410d2c81c858ace72340 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Fauconnier?= <fc86@outlook.fr>
Date: Tue, 12 Jun 2018 17:00:18 +0200
Subject: [PATCH] changed checkbox name and simplified code for
 swapDisplayScreens

---
 resources/forms/preferences.ui |  2 +-
 src/core/UBDisplayManager.cpp  | 41 +---------------------------------
 2 files changed, 2 insertions(+), 41 deletions(-)

diff --git a/resources/forms/preferences.ui b/resources/forms/preferences.ui
index 331aea8e..d5ba1c62 100644
--- a/resources/forms/preferences.ui
+++ b/resources/forms/preferences.ui
@@ -134,7 +134,7 @@
           <item row="2" column="3">
            <widget class="QCheckBox" name="swapDisplayScreensCheckBox">
             <property name="text">
-             <string>Swap first and second displays</string>
+             <string>Swap first and second view displays</string>
             </property>
            </widget>
           </item>
diff --git a/src/core/UBDisplayManager.cpp b/src/core/UBDisplayManager.cpp
index db5c1318..3d76ebb6 100644
--- a/src/core/UBDisplayManager.cpp
+++ b/src/core/UBDisplayManager.cpp
@@ -109,46 +109,7 @@ void UBDisplayManager::initScreenIndexes()
 
 void UBDisplayManager::swapDisplayScreens(bool swap)
 {
-    int screenCount = numScreens();
-
-    mScreenIndexesRoles.clear();
-
-    if (screenCount > 0)
-    {
-        mControlScreenIndex = mDesktop->primaryScreen();
-        if (screenCount > 1 && UBSettings::settings()->swapControlAndDisplayScreens->get().toBool())
-        {
-            mControlScreenIndex = mControlScreenIndex^1;
-        }
-        mScreenIndexesRoles << Control;
-    }
-    else
-    {
-        mControlScreenIndex = -1;
-    }
-
-    if (screenCount > 1 && mUseMultiScreen)
-    {
-        mDisplayScreenIndex = mControlScreenIndex != 0 ? 0 : 1;
-        mScreenIndexesRoles << Display;
-    }
-    else
-    {
-        mDisplayScreenIndex = -1;
-    }
-
-    mPreviousScreenIndexes.clear();
-
-    if (screenCount > 2)
-    {
-        for(int i = 2; i < screenCount; i++)
-        {
-            if(mControlScreenIndex == i)
-                mPreviousScreenIndexes.append(1);
-            else
-                mPreviousScreenIndexes.append(i);
-        }
-    }
+    initScreenIndexes();
 
     if (swap)
     {