MAC warnings fix

src/board/UBBoardView.cpp

@@ -426,7 +426,10 @@ bool UBBoardView::itemShouldReceiveMousePressEvent(QGraphicsItem *item)
     UBStylusTool::Enum currentTool = (UBStylusTool::Enum)UBDrawingController::drawingController()->stylusTool();
 
     if ((currentTool == UBStylusTool::Play) && UBGraphicsGroupContainerItem::Type == movingItem->type())
-        return movingItem = NULL;
+    {
+        movingItem = NULL;
+        return false;
+    }
 
     switch(item->type())
     {
@@ -534,11 +537,7 @@ bool UBBoardView::itemShouldBeMoved(QGraphicsItem *item)
         return true;
     case UBGraphicsTextItem::Type:
         return !item->isSelected();
-
-    default: 
-        false;
     }
-
     return false;
 }
 

src/domain/UBGraphicsMediaItem.cpp

@@ -57,10 +57,10 @@ UBGraphicsMediaItem::UBGraphicsMediaItem(const QUrl& pMediaFileUrl, QGraphicsIte
         , mMuted(sIsMutedByDefault)
         , mMutedByUserAction(sIsMutedByDefault)
         , mMediaFileUrl(pMediaFileUrl)
-        , mInitialPos(0)
         , mVideoWidget(NULL)
         , mAudioWidget(NULL)
         , mLinkedImage(NULL)
+        , mInitialPos(0)
 {
     update();
 

src/domain/UBGraphicsScene.cpp

@@ -256,8 +256,8 @@ UBGraphicsScene::UBGraphicsScene(UBDocumentProxy* parent)
     , mDocument(parent)
     , mDarkBackground(false)
     , mCrossedBackground(false)
-    , mZoomFactor(1)
     , mIsDesktopMode(false)
+    , mZoomFactor(1)
     , mIsModified(true)
     , mBackgroundObject(0)
     , mPreviousWidth(0)

src/gui/UBRubberBand.cpp

@@ -33,8 +33,8 @@ UBRubberBand::UBRubberBand(Shape s, QWidget * p)
     : QRubberBand(s, p)
     , mResizingMode(None)
     , mMouseIsPressed(false)
-    , mLastPressedPoint(QPoint())
     , mResizingBorderHeight(20)
+    , mLastPressedPoint(QPoint())
 {
     customStyle = NULL;
 

src/podcast/quicktime/UBAudioQueueRecorder.cpp

@@ -139,7 +139,7 @@ QString UBAudioQueueRecorder::deviceUIDFromDeviceID(AudioDeviceID id)
     {
         char *cname = new char[1024];
 
-        bool result = CFStringGetCString (name, cname, 1024, kCFStringEncodingASCII);
+        CFStringGetCString (name, cname, 1024, kCFStringEncodingASCII);
         int length = CFStringGetLength (name);
 
         uid = QString::fromAscii(cname, length);

src/podcast/quicktime/UBQuickTimeFile.cpp

@@ -151,7 +151,7 @@ bool UBQuickTimeFile::createCompressionSession()
     }
 
     OSStatus err = noErr;
-    ICMEncodedFrameOutputRecord encodedFrameOutputRecord = {0};
+    ICMEncodedFrameOutputRecord encodedFrameOutputRecord = {NULL, NULL, NULL};
     ICMCompressionSessionOptionsRef sessionOptions = 0;
 
     err = ICMCompressionSessionOptionsCreate(0, &sessionOptions);