diff --git a/resources/library/applications/Grapheur.wgt/Grapheur.xhtml b/resources/library/applications/Grapheur.wgt/Grapheur.xhtml
index 3a94a9d3..bfca757c 100644
--- a/resources/library/applications/Grapheur.wgt/Grapheur.xhtml
+++ b/resources/library/applications/Grapheur.wgt/Grapheur.xhtml
@@ -218,7 +218,6 @@
return true;
});
$("label[for*='checkAire']").text(sankoreLang[lang].draw);
- $("label[for*='checkMaJ']").text(sankoreLang[lang].auto_update);
$("#menuOptions td").eq(0).html(sankoreLang[lang].widget);
$("#menuOptions h3").eq(0).text(sankoreLang[lang].widget_options);
$("#menuOptions2D h3").eq(0).text(sankoreLang[lang].options + " 2D");
@@ -1033,13 +1032,10 @@
Control options:
Save a widget options in cookies or load an options from cookies or delete a registered options.
-
-
Cookies are disabled. You cannot save an options...
You are using the last version of this widget.
-
diff --git a/resources/library/interactivities/Contraste.wgt/locales/fr/scripts/blackYellow.js b/resources/library/interactivities/Contraste.wgt/locales/fr/scripts/blackYellow.js
index 34de0859..3fbfd9aa 100644
--- a/resources/library/interactivities/Contraste.wgt/locales/fr/scripts/blackYellow.js
+++ b/resources/library/interactivities/Contraste.wgt/locales/fr/scripts/blackYellow.js
@@ -326,6 +326,15 @@ function init(){
$(".closeItem").live("click", function(){
if(!shadowOver){
$(this).parent().remove();
+ if($(".editContainer").size() > 0){
+ var prev = $(".editContainer:first");
+ if((prev.position().left == 54) && (prev.position().top != 60))
+ prev.css("top", "60px");
+ var prevBottom = prev.position().top + prev.height(),
+ prevLeft = prev.position().left;
+ if(prev.next().length)
+ recursionCall(prevBottom, prevLeft, prev.next());
+ }
}
});
@@ -339,8 +348,7 @@ function init(){
})
function recursionCall(prevBottom, prevLeft, curr){
- var curTop = curr.position().top,
- curHeight = curr.height(),
+ var curHeight = curr.height(),
curLeft = curr.position().left;
if(prevLeft == curLeft){
if((prevBottom + 15 + curHeight) < ($(window).height() - 54))
@@ -351,7 +359,7 @@ function init(){
if((prevBottom + 15 + curHeight) < ($(window).height() - 54))
curr.css("top", prevBottom + 15 + "px").css("left", prevLeft + "px");
else
- curr.css("top", "60px");
+ curr.css("top", "60px").css("left", prevLeft + 255 + "px");
}
prevBottom = curr.position().top + curr.height(),
prevLeft = curr.position().left;
@@ -364,7 +372,20 @@ function init(){
popupBack.css("left", ($(window).width() - 360)*50/$(window).width() + "%");
$(window).resize(function(){
- //$("#leftDiv,#rightDiv,#shadowDiv").css("height", $(window).height());
+ if($("#wgt_edit").hasClass("selected")){
+ if($(".editContainer").size() > 1){
+ var prev = $(".editContainer:first"),
+ prevBottom = prev.position().top + prev.height(),
+ prevLeft = prev.position().left;
+ recursionCall(prevBottom, prevLeft, prev.next());
+ }
+ } else {
+ var tmp_array = [];
+ $(".readyTask").each(function(){
+ tmp_array.push($(this));
+ });
+ orderItems(tmp_array);
+ }
popupBack.css("top", ($(window).height() - 138)*50/$(window).height() + "%");
popupBack.css("left", ($(window).width() - 360)*50/$(window).width() + "%");
});
@@ -564,4 +585,4 @@ function changeStyle(val){
}
if($("#wgt_edit").hasClass("selected"))
$(document).enableTextSelect();
-}
\ No newline at end of file
+}
diff --git a/resources/library/interactivities/Contraste.wgt/locales/ru/scripts/blackYellow.js b/resources/library/interactivities/Contraste.wgt/locales/ru/scripts/blackYellow.js
index fce0a9af..fc0eb152 100644
--- a/resources/library/interactivities/Contraste.wgt/locales/ru/scripts/blackYellow.js
+++ b/resources/library/interactivities/Contraste.wgt/locales/ru/scripts/blackYellow.js
@@ -326,6 +326,15 @@ function init(){
$(".closeItem").live("click", function(){
if(!shadowOver){
$(this).parent().remove();
+ if($(".editContainer").size() > 0){
+ var prev = $(".editContainer:first");
+ if((prev.position().left == 54) && (prev.position().top != 60))
+ prev.css("top", "60px");
+ var prevBottom = prev.position().top + prev.height(),
+ prevLeft = prev.position().left;
+ if(prev.next().length)
+ recursionCall(prevBottom, prevLeft, prev.next());
+ }
}
});
@@ -339,8 +348,7 @@ function init(){
})
function recursionCall(prevBottom, prevLeft, curr){
- var curTop = curr.position().top,
- curHeight = curr.height(),
+ var curHeight = curr.height(),
curLeft = curr.position().left;
if(prevLeft == curLeft){
if((prevBottom + 15 + curHeight) < ($(window).height() - 54))
@@ -351,7 +359,7 @@ function init(){
if((prevBottom + 15 + curHeight) < ($(window).height() - 54))
curr.css("top", prevBottom + 15 + "px").css("left", prevLeft + "px");
else
- curr.css("top", "60px");
+ curr.css("top", "60px").css("left", prevLeft + 255 + "px");
}
prevBottom = curr.position().top + curr.height(),
prevLeft = curr.position().left;
@@ -364,7 +372,20 @@ function init(){
popupBack.css("left", ($(window).width() - 360)*50/$(window).width() + "%");
$(window).resize(function(){
- //$("#leftDiv,#rightDiv,#shadowDiv").css("height", $(window).height());
+ if($("#wgt_edit").hasClass("selected")){
+ if($(".editContainer").size() > 1){
+ var prev = $(".editContainer:first"),
+ prevBottom = prev.position().top + prev.height(),
+ prevLeft = prev.position().left;
+ recursionCall(prevBottom, prevLeft, prev.next());
+ }
+ } else {
+ var tmp_array = [];
+ $(".readyTask").each(function(){
+ tmp_array.push($(this));
+ });
+ orderItems(tmp_array);
+ }
popupBack.css("top", ($(window).height() - 138)*50/$(window).height() + "%");
popupBack.css("left", ($(window).width() - 360)*50/$(window).width() + "%");
});
@@ -564,4 +585,4 @@ function changeStyle(val){
}
if($("#wgt_edit").hasClass("selected"))
$(document).enableTextSelect();
-}
\ No newline at end of file
+}
diff --git a/resources/library/interactivities/Contraste.wgt/scripts/blackYellow.js b/resources/library/interactivities/Contraste.wgt/scripts/blackYellow.js
index 27035aaf..89e6df3f 100644
--- a/resources/library/interactivities/Contraste.wgt/scripts/blackYellow.js
+++ b/resources/library/interactivities/Contraste.wgt/scripts/blackYellow.js
@@ -326,6 +326,15 @@ function init(){
$(".closeItem").live("click", function(){
if(!shadowOver){
$(this).parent().remove();
+ if($(".editContainer").size() > 0){
+ var prev = $(".editContainer:first");
+ if((prev.position().left == 54) && (prev.position().top != 60))
+ prev.css("top", "60px");
+ var prevBottom = prev.position().top + prev.height(),
+ prevLeft = prev.position().left;
+ if(prev.next().length)
+ recursionCall(prevBottom, prevLeft, prev.next());
+ }
}
});
@@ -339,8 +348,7 @@ function init(){
})
function recursionCall(prevBottom, prevLeft, curr){
- var curTop = curr.position().top,
- curHeight = curr.height(),
+ var curHeight = curr.height(),
curLeft = curr.position().left;
if(prevLeft == curLeft){
if((prevBottom + 15 + curHeight) < ($(window).height() - 54))
@@ -351,7 +359,7 @@ function init(){
if((prevBottom + 15 + curHeight) < ($(window).height() - 54))
curr.css("top", prevBottom + 15 + "px").css("left", prevLeft + "px");
else
- curr.css("top", "60px");
+ curr.css("top", "60px").css("left", prevLeft + 255 + "px");
}
prevBottom = curr.position().top + curr.height(),
prevLeft = curr.position().left;
@@ -364,7 +372,20 @@ function init(){
popupBack.css("left", ($(window).width() - 360)*50/$(window).width() + "%");
$(window).resize(function(){
- //$("#leftDiv,#rightDiv,#shadowDiv").css("height", $(window).height());
+ if($("#wgt_edit").hasClass("selected")){
+ if($(".editContainer").size() > 1){
+ var prev = $(".editContainer:first"),
+ prevBottom = prev.position().top + prev.height(),
+ prevLeft = prev.position().left;
+ recursionCall(prevBottom, prevLeft, prev.next());
+ }
+ } else {
+ var tmp_array = [];
+ $(".readyTask").each(function(){
+ tmp_array.push($(this));
+ });
+ orderItems(tmp_array);
+ }
popupBack.css("top", ($(window).height() - 138)*50/$(window).height() + "%");
popupBack.css("left", ($(window).width() - 360)*50/$(window).width() + "%");
});
diff --git a/resources/library/interactivities/Ordre phrase.wgt/styles/of_puppets.css b/resources/library/interactivities/Ordre phrase.wgt/styles/of_puppets.css
index 6589dcef..401a2bea 100644
--- a/resources/library/interactivities/Ordre phrase.wgt/styles/of_puppets.css
+++ b/resources/library/interactivities/Ordre phrase.wgt/styles/of_puppets.css
@@ -33,7 +33,6 @@ body{
font: 28px tahoma;
text-align: center;
cursor: pointer;
- text-transform: uppercase;
overflow: hidden;
}
diff --git a/src/adaptors/UBCFFSubsetAdaptor.cpp b/src/adaptors/UBCFFSubsetAdaptor.cpp
index 7eb667b5..87c83cc4 100644
--- a/src/adaptors/UBCFFSubsetAdaptor.cpp
+++ b/src/adaptors/UBCFFSubsetAdaptor.cpp
@@ -174,9 +174,7 @@ bool UBCFFSubsetAdaptor::UBCFFSubsetReader::parseGSection(const QDomElement &ele
QDomElement currentSvgElement = element.firstChildElement();
while (!currentSvgElement.isNull()) {
- if (!parseSvgElement(currentSvgElement))
- return false;
-
+ parseSvgElement(currentSvgElement);
currentSvgElement = currentSvgElement.nextSiblingElement();
}
@@ -187,8 +185,8 @@ bool UBCFFSubsetAdaptor::UBCFFSubsetReader::parseGSection(const QDomElement &ele
else
{
delete mGSectionContainer;
- mGSectionContainer = NULL;
}
+ mGSectionContainer = NULL;
return true;
}
@@ -1189,8 +1187,6 @@ bool UBCFFSubsetAdaptor::UBCFFSubsetReader::persistScenes()
UBGraphicsScene *tmpScene = UBSvgSubsetAdaptor::loadScene(mProxy, i);
tmpScene->setModified(true);
UBThumbnailAdaptor::persistScene(mProxy, tmpScene, i);
- delete tmpScene;
-
mCurrentScene->setModified(false);
}
diff --git a/src/board/UBBoardController.cpp b/src/board/UBBoardController.cpp
index c0be0da8..b7a5ad6b 100644
--- a/src/board/UBBoardController.cpp
+++ b/src/board/UBBoardController.cpp
@@ -553,15 +553,15 @@ void UBBoardController::duplicateItem(UBItem *item)
qreal shifting = UBSettings::settings()->objectFrameWidth;
itemPos = commonItem->pos() + QPointF(shifting,shifting);
itemSize = commonItem->boundingRect().size();
+ commonItem->setSelected(false);
}
UBMimeType::Enum itemMimeType;
QString contentTypeHeader = UBFileSystemUtils::mimeTypeFromFileName(item->sourceUrl().toLocalFile());
- if(NULL != qgraphicsitem_cast(commonItem)){
- itemMimeType = UBMimeType::Group;
- }else{
- itemMimeType = UBFileSystemUtils::mimeTypeFromString(contentTypeHeader);
- }
+ if(NULL != qgraphicsitem_cast(commonItem))
+ itemMimeType = UBMimeType::Group;
+ else
+ itemMimeType = UBFileSystemUtils::mimeTypeFromString(contentTypeHeader);
switch(static_cast(itemMimeType))
{
@@ -633,10 +633,10 @@ void UBBoardController::duplicateItem(UBItem *item)
QGraphicsItem *gitem = dynamic_cast(item->deepCopy());
if (gitem)
{
- qDebug() << "Adding a stroke: " << gitem;
mActiveScene->addItem(gitem);
gitem->setPos(itemPos);
mLastCreatedItem = gitem;
+ gitem->setSelected(true);
}
return;
}break;
@@ -1482,11 +1482,12 @@ void UBBoardController::ClearUndoStack()
UBGraphicsItemUndoCommand *cmd = (UBGraphicsItemUndoCommand*)UBApplication::undoStack->command(i);
// go through all added and removed objects, for create list of unique objects
+ // grouped items will be deleted by groups, so we don't need do delete that items.
QSetIterator itAdded(cmd->GetAddedList());
while (itAdded.hasNext())
{
QGraphicsItem* item = itAdded.next();
- if( !uniqueItems.contains(item) )
+ if( !uniqueItems.contains(item) && !(item->parentItem() && UBGraphicsGroupContainerItem::Type == item->parentItem()->type()))
uniqueItems.insert(item);
}
@@ -1494,7 +1495,7 @@ void UBBoardController::ClearUndoStack()
while (itRemoved.hasNext())
{
QGraphicsItem* item = itRemoved.next();
- if( !uniqueItems.contains(item) )
+ if( !uniqueItems.contains(item) && !(item->parentItem() && UBGraphicsGroupContainerItem::Type == item->parentItem()->type()))
uniqueItems.insert(item);
}
}
@@ -1515,7 +1516,8 @@ void UBBoardController::ClearUndoStack()
}
if(!scene)
{
- mActiveScene->deleteItem(item);
+ if (!mActiveScene->deleteItem(item))
+ delete item;
}
}
diff --git a/src/board/UBBoardPaletteManager.cpp b/src/board/UBBoardPaletteManager.cpp
index 5c55521c..2652bb15 100644
--- a/src/board/UBBoardPaletteManager.cpp
+++ b/src/board/UBBoardPaletteManager.cpp
@@ -710,9 +710,7 @@ void UBBoardPaletteManager::changeMode(eUBDockPaletteWidgetMode newMode, bool is
mLeftPalette->assignParent((QWidget*)UBApplication::applicationController->uninotesController()->drawingView());
mRightPalette->assignParent((QWidget*)UBApplication::applicationController->uninotesController()->drawingView());
mStylusPalette->raise();
- // Maybe threre is a reason to keep that functions but with them right palette in desktop mode is not interactable
- // mRightPalette->lower();
- // mLeftPalette->lower();
+
if (UBPlatformUtils::hasVirtualKeyboard() && mKeyboardPalette != NULL)
{
diff --git a/src/board/UBBoardView.cpp b/src/board/UBBoardView.cpp
index ed75f550..5500ec9b 100644
--- a/src/board/UBBoardView.cpp
+++ b/src/board/UBBoardView.cpp
@@ -528,6 +528,8 @@ Here we determines cases when items should to get mouse press event at pressing
return true;
case DelegateButton::Type:
+ return true;
+
case UBGraphicsMediaItem::Type:
return false;
@@ -1123,6 +1125,7 @@ UBBoardView::mouseReleaseEvent (QMouseEvent *event)
else
{
if (isUBItem(movingItem) &&
+ DelegateButton::Type != movingItem->type() &&
QGraphicsSvgItem::Type != movingItem->type() &&
UBGraphicsDelegateFrame::Type != movingItem->type() &&
UBToolWidget::Type != movingItem->type() &&
diff --git a/src/core/UBApplication.cpp b/src/core/UBApplication.cpp
index d3aed832..94f0710e 100644
--- a/src/core/UBApplication.cpp
+++ b/src/core/UBApplication.cpp
@@ -139,15 +139,7 @@ UBApplication::UBApplication(const QString &id, int &argc, char **argv) : QtSing
UBSettings *settings = UBSettings::settings();
- QString forcedLanguage("");
- if(args.contains("-lang"))
- forcedLanguage=args.at(args.indexOf("-lang") + 1);
- else{
- QString setLanguage = settings->appPreferredLanguage->get().toString();
- if(!setLanguage.isEmpty())
- forcedLanguage = setLanguage;
- }
- setupTranslator(forcedLanguage);
+ setupTranslators(args);
connect(settings->appToolBarPositionedAtTop, SIGNAL(changed(QVariant)), this, SLOT(toolBarPositionChanged(QVariant)));
connect(settings->appToolBarDisplayText, SIGNAL(changed(QVariant)), this, SLOT(toolBarDisplayTextChanged(QVariant)));
@@ -207,45 +199,71 @@ UBApplication::~UBApplication()
staticMemoryCleaner = 0;
}
-void UBApplication::setupTranslator(QString forcedLanguage)
+QString UBApplication::checkLanguageAvailabilityForSankore(QString &language)
{
- QStringList availablesTranslations = UBPlatformUtils::availableTranslations();
- QString language("");
- if(!forcedLanguage.isEmpty()){
- if(availablesTranslations.contains(forcedLanguage,Qt::CaseInsensitive))
- language = forcedLanguage;
- else
- qDebug() << "forced language " << forcedLanguage << " not available";
- }
- else{
- QString systemLanguage = UBPlatformUtils::systemLanguage();
- if(availablesTranslations.contains(systemLanguage,Qt::CaseInsensitive))
- language = systemLanguage;
- else
- qDebug() << "translation for system language " << systemLanguage << " not found";
- }
-
- if(language.isEmpty()){
- language = "en_US";
- //fallback if no translation are available
- }
- else{
- mApplicationTranslator = new QTranslator(this);
- mQtGuiTranslator = new QTranslator(this);
+ QStringList availableTranslations = UBPlatformUtils::availableTranslations();
+ if(availableTranslations.contains(language,Qt::CaseInsensitive))
+ return language;
+ else{
+ if(language.length() > 2){
+ QString shortLanguageCode = language.left(2);
+ if(availableTranslations.contains(shortLanguageCode,Qt::CaseInsensitive))
+ return shortLanguageCode;
+ }
+ }
+ return QString("");
+}
+
+void UBApplication::setupTranslators(QStringList args)
+{
+ QString forcedLanguage;
+ if(args.contains("-lang"))
+ forcedLanguage=args.at(args.indexOf("-lang") + 1);
+ else{
+ QString setLanguage = UBSettings::settings()->appPreferredLanguage->get().toString();
+ if(!setLanguage.isEmpty())
+ forcedLanguage = setLanguage;
+ }
+
+ QStringList availablesTranslations = UBPlatformUtils::availableTranslations();
+ QString language("");
+
+ if(!forcedLanguage.isEmpty())
+ language = checkLanguageAvailabilityForSankore(forcedLanguage);
+
+ if(language.isEmpty()){
+ QString systemLanguage = UBPlatformUtils::systemLanguage();
+ language = checkLanguageAvailabilityForSankore(systemLanguage);
+ }
+
+ if(language.isEmpty()){
+ language = "en_US";
+ //fallback if no translation are available
+ }
+ else{
+ mApplicationTranslator = new QTranslator(this);
+ mQtGuiTranslator = new QTranslator(this);
mApplicationTranslator->load(UBPlatformUtils::translationPath(QString("sankore_"),language));
- installTranslator(mApplicationTranslator);
+ installTranslator(mApplicationTranslator);
+
+ QString qtGuiTranslationPath = UBPlatformUtils::translationPath("qt_", language);
- mQtGuiTranslator->load(UBPlatformUtils::translationPath(QString("qt_"),language));
- if(!mQtGuiTranslator->isEmpty()){
- // checked because this translation could be not available
- installTranslator(mQtGuiTranslator);
- }
- else
- qDebug() << "Qt gui translation in " << language << " are not available";
- }
+ if(!QFile(qtGuiTranslationPath).exists()){
+ qtGuiTranslationPath = UBPlatformUtils::translationPath("qt_", language.left(2));
+ if(!QFile(qtGuiTranslationPath).exists())
+ qtGuiTranslationPath = "";
+ }
+ if(!qtGuiTranslationPath.isEmpty()){
+ qDebug() << "qtGuiTranslationPath " << qtGuiTranslationPath;
+ mQtGuiTranslator->load(qtGuiTranslationPath);
+ installTranslator(mQtGuiTranslator);
+ }
+ else
+ qDebug() << "Qt gui translation in " << language << " is not available";
+ }
QLocale::setDefault(QLocale(language));
qDebug() << "Running application in:" << language;
diff --git a/src/core/UBApplication.h b/src/core/UBApplication.h
index b4060d54..b08fdcee 100644
--- a/src/core/UBApplication.h
+++ b/src/core/UBApplication.h
@@ -119,10 +119,10 @@ class UBApplication : public QtSingleApplication
private:
void updateProtoActionsState();
- void setupTranslator(QString forcedLanguage);
+ void setupTranslators(QStringList args);
QList mProtoMenus;
bool mIsVerbose;
-
+ QString checkLanguageAvailabilityForSankore(QString& language);
protected:
#if defined(Q_WS_MACX) && !defined(QT_MAC_USE_COCOA)
diff --git a/src/desktop/UBDesktopAnnotationController.cpp b/src/desktop/UBDesktopAnnotationController.cpp
index 6ca9ba87..e86dca46 100644
--- a/src/desktop/UBDesktopAnnotationController.cpp
+++ b/src/desktop/UBDesktopAnnotationController.cpp
@@ -86,7 +86,7 @@ UBDesktopAnnotationController::UBDesktopAnnotationController(QObject *parent)
mTransparentDrawingView->setScene(mTransparentDrawingScene);
mTransparentDrawingScene->setDrawingMode(true);
- mDesktopPalette = new UBDesktopPalette(mTransparentDrawingView);
+ mDesktopPalette = new UBDesktopPalette(NULL); // FIX #633: The palette must be 'floating' in order to stay on top of the library palette
if (UBPlatformUtils::hasVirtualKeyboard())
{
@@ -119,13 +119,13 @@ UBDesktopAnnotationController::UBDesktopAnnotationController(QObject *parent)
connect(UBDrawingController::drawingController(), SIGNAL(stylusToolChanged(int)), this, SLOT(stylusToolChanged(int)));
// Add the desktop associated palettes
- mDesktopPenPalette = new UBDesktopPenPalette(mTransparentDrawingView);
+ mDesktopPenPalette = new UBDesktopPenPalette(NULL); // FIX #633: The palette must be 'floating' in order to stay on top of the library palette
connect(mDesktopPalette, SIGNAL(maximized()), mDesktopPenPalette, SLOT(onParentMaximized()));
connect(mDesktopPalette, SIGNAL(minimizeStart(eMinimizedLocation)), mDesktopPenPalette, SLOT(onParentMinimized()));
- mDesktopMarkerPalette = new UBDesktopMarkerPalette(mTransparentDrawingView);
- mDesktopEraserPalette = new UBDesktopEraserPalette(mTransparentDrawingView);
+ mDesktopMarkerPalette = new UBDesktopMarkerPalette(NULL); // FIX #633: The palette must be 'floating' in order to stay on top of the library palette
+ mDesktopEraserPalette = new UBDesktopEraserPalette(NULL); // FIX #633: The palette must be 'floating' in order to stay on top of the library palette
mDesktopPalette->setBackgroundBrush(UBSettings::settings()->opaquePaletteColor);
mDesktopPenPalette->setBackgroundBrush(UBSettings::settings()->opaquePaletteColor);
@@ -154,6 +154,12 @@ UBDesktopAnnotationController::UBDesktopAnnotationController(QObject *parent)
connect(UBApplication::boardController->paletteManager()->rightPalette(), SIGNAL(resized()), this, SLOT(refreshMask()));
#endif
onDesktopPaletteMaximized();
+
+ // FIX #633: Ensure that these palettes stay on top of the other elements
+ mDesktopEraserPalette->raise();
+ mDesktopMarkerPalette->raise();
+ mDesktopPenPalette->raise();
+ mDesktopPalette->raise();
}
UBDesktopAnnotationController::~UBDesktopAnnotationController()
@@ -243,11 +249,7 @@ void UBDesktopAnnotationController::setAssociatedPalettePosition(UBActionPalette
if(act->objectName() == actionName)
{
int iAction = actions.indexOf(act);
- yPen = iAction * mDesktopPalette->buttonSize().height();
-
- // Add the borders
- yPen += (iAction) * (mDesktopPalette->border() + 4); // 4 has been set after some experiment. We must determine why this value is good
-
+ yPen = iAction * (mDesktopPalette->buttonSize().height() + 2 * mDesktopPalette->border() +6); // This is the mysterious value (6)
break;
}
}
diff --git a/src/document/UBDocumentController.cpp b/src/document/UBDocumentController.cpp
index 4be9ee0f..af8734e6 100755
--- a/src/document/UBDocumentController.cpp
+++ b/src/document/UBDocumentController.cpp
@@ -117,8 +117,11 @@ UBDocumentProxyTreeItem* UBDocumentController::findDocument(UBDocumentProxy* pro
void UBDocumentController::selectDocument(UBDocumentProxy* proxy, bool setAsCurrentDocument)
{
- if (!proxy)
+ if (proxy==NULL)
+ {
+ setDocument(NULL);
return;
+ }
QTreeWidgetItemIterator it(mDocumentUI->documentTreeWidget);
@@ -531,6 +534,153 @@ void UBDocumentController::duplicateSelectedItem()
}
}
+void UBDocumentController::moveDocumentToTrash(UBDocumentGroupTreeItem* groupTi, UBDocumentProxyTreeItem *proxyTi)
+{
+ int index = proxyTi->parent()->indexOfChild(proxyTi);
+ index --;
+
+ if (index >= 0)
+ {
+ if (proxyTi->proxy() == mBoardController->selectedDocument())
+ {
+ selectDocument(((UBDocumentProxyTreeItem*)proxyTi->parent()->child(index))->proxy(), true);
+ }
+ else
+ proxyTi->parent()->child(index)->setSelected(true);
+ }
+ else if (proxyTi->parent()->childCount() > 1)
+ {
+ if (proxyTi->proxy() == mBoardController->selectedDocument())
+ {
+ selectDocument(((UBDocumentProxyTreeItem*)proxyTi->parent()->child(1))->proxy(), true);
+ }
+ else
+ proxyTi->parent()->child(1)->setSelected(true);
+ }
+ else
+ {
+ if (proxyTi->proxy() == mBoardController->selectedDocument())
+ {
+ bool documentFound = false;
+ for (int i = 0; i < mDocumentUI->documentTreeWidget->topLevelItemCount(); i++)
+ {
+ QTreeWidgetItem* item = mDocumentUI->documentTreeWidget->topLevelItem(i);
+ UBDocumentGroupTreeItem* groupItem = dynamic_cast(item);
+ if (!groupItem->isTrashFolder())
+ {
+ for(int j=0; jchildCount(); j++)
+ {
+ if (((UBDocumentProxyTreeItem*)groupItem->child(j))->proxy() != mBoardController->selectedDocument())
+ {
+ selectDocument(((UBDocumentProxyTreeItem*)groupItem->child(0))->proxy(), true);
+ documentFound = true;
+ break;
+ }
+ }
+ }
+ if (documentFound)
+ break;
+ }
+ if (!documentFound)
+ {
+ UBDocumentProxy *document = UBPersistenceManager::persistenceManager()->createDocument(groupTi->groupName());
+ selectDocument(document, true);
+ }
+ }
+ else
+ proxyTi->parent()->setSelected(true);
+ }
+
+ QString oldGroupName = proxyTi->proxy()->metaData(UBSettings::documentGroupName).toString();
+ proxyTi->proxy()->setMetaData(UBSettings::documentGroupName, UBSettings::trashedDocumentGroupNamePrefix + oldGroupName);
+ UBPersistenceManager::persistenceManager()->persistDocumentMetadata(proxyTi->proxy());
+
+ proxyTi->parent()->removeChild(proxyTi);
+ mTrashTi->addChild(proxyTi);
+ proxyTi->setFlags(proxyTi->flags() ^ Qt::ItemIsEditable);
+}
+
+void UBDocumentController::moveFolderToTrash(UBDocumentGroupTreeItem* groupTi)
+{
+ bool changeCurrentDocument = false;
+ for (int i = 0; i < groupTi->childCount(); i++)
+ {
+ UBDocumentProxyTreeItem* proxyTi = dynamic_cast(groupTi->child(i));
+ if (proxyTi && proxyTi->proxy() && proxyTi->proxy() == mBoardController->selectedDocument())
+ {
+ changeCurrentDocument = true;
+ break;
+ }
+ }
+
+ QList toBeDeleted;
+
+ for (int i = 0; i < groupTi->childCount(); i++)
+ {
+ UBDocumentProxyTreeItem* proxyTi = dynamic_cast(groupTi->child(i));
+ if (proxyTi && proxyTi->proxy())
+ toBeDeleted << proxyTi;
+ }
+
+ for (int i = 0; i < toBeDeleted.count(); i++)
+ {
+ UBDocumentProxyTreeItem* proxyTi = toBeDeleted.at(i);
+
+ showMessage(QString("Deleting %1").arg(proxyTi->proxy()->metaData(UBSettings::documentName).toString()));
+ // Move document to trash
+ QString oldGroupName = proxyTi->proxy()->metaData(UBSettings::documentGroupName).toString();
+ proxyTi->proxy()->setMetaData(UBSettings::documentGroupName, UBSettings::trashedDocumentGroupNamePrefix + oldGroupName);
+ UBPersistenceManager::persistenceManager()->persistDocumentMetadata(proxyTi->proxy());
+
+ groupTi->removeChild(proxyTi);
+ mTrashTi->addChild(proxyTi);
+ proxyTi->setFlags(proxyTi->flags() ^ Qt::ItemIsEditable);
+
+ showMessage(QString("%1 deleted").arg(groupTi->groupName()));
+ }
+
+ // dont remove default group
+ if (!groupTi->isDefaultFolder())
+ {
+ int index = mDocumentUI->documentTreeWidget->indexOfTopLevelItem(groupTi);
+
+ if (index >= 0)
+ {
+ mDocumentUI->documentTreeWidget->takeTopLevelItem(index);
+ }
+ }
+
+ if (changeCurrentDocument)
+ {
+ bool documentFound = false;
+ for (int i = 0; i < mDocumentUI->documentTreeWidget->topLevelItemCount(); i++)
+ {
+ QTreeWidgetItem* item = mDocumentUI->documentTreeWidget->topLevelItem(i);
+ UBDocumentGroupTreeItem* groupItem = dynamic_cast(item);
+ if (!groupItem->isTrashFolder() && groupItem != groupTi)
+ {
+ for(int j=0; jchildCount(); j++)
+ {
+ if (((UBDocumentProxyTreeItem*)groupItem->child(j))->proxy() != mBoardController->selectedDocument())
+ {
+ selectDocument(((UBDocumentProxyTreeItem*)groupItem->child(0))->proxy(), true);
+ documentFound = true;
+ break;
+ }
+ }
+ }
+ if (documentFound)
+ break;
+ }
+ if (!documentFound)
+ {
+ UBDocumentProxy *document = UBPersistenceManager::persistenceManager()->createDocument( UBSettings::defaultDocumentGroupName );
+ selectDocument(document, true);
+ }
+ }
+
+ reloadThumbnails();
+}
void UBDocumentController::deleteSelectedItem()
{
@@ -553,79 +703,19 @@ void UBDocumentController::deleteSelectedItem()
{
if (proxyTi->parent() != mTrashTi)
{
- // We have to move document into Trash
- // Select another document for processing
- // This is for Board, where this document can be selected
- int index = proxyTi->parent()->indexOfChild(proxyTi);
- index --;
-
- if (index >= 0)
- {
- if (proxyTi->proxy() == mBoardController->selectedDocument())
- {
- selectDocument(((UBDocumentProxyTreeItem*)proxyTi->parent()->child(index))->proxy(), true);
- }
- else
- proxyTi->parent()->child(index)->setSelected(true);
- }
- else if (proxyTi->parent()->childCount() > 1)
- {
- if (proxyTi->proxy() == mBoardController->selectedDocument())
- {
- selectDocument(((UBDocumentProxyTreeItem*)proxyTi->parent()->child(1))->proxy(), true);
- }
- else
- proxyTi->parent()->child(1)->setSelected(true);
- }
- else
- {
- if (proxyTi->proxy() == mBoardController->selectedDocument())
- {
- bool documentFound = false;
- for (int i = 0; i < mDocumentUI->documentTreeWidget->topLevelItemCount(); i++)
- {
- QTreeWidgetItem* item = mDocumentUI->documentTreeWidget->topLevelItem(i);
- UBDocumentGroupTreeItem* groupItem = dynamic_cast(item);
- if (!groupItem->isTrashFolder())
- {
- for(int j=0; jchildCount(); j++)
- {
- if (((UBDocumentProxyTreeItem*)groupItem->child(j))->proxy() != mBoardController->selectedDocument())
- {
- selectDocument(((UBDocumentProxyTreeItem*)groupItem->child(0))->proxy(), true);
- documentFound = true;
- break;
- }
- }
- }
- if (documentFound)
- break;
- }
- if (!documentFound)
- {
- UBDocumentProxy *document = UBPersistenceManager::persistenceManager()->createDocument(groupTi->groupName());
- selectDocument(document, true);
- }
- }
- else
- proxyTi->parent()->setSelected(true);
- }
-
- QString oldGroupName = proxyTi->proxy()->metaData(UBSettings::documentGroupName).toString();
- proxyTi->proxy()->setMetaData(UBSettings::documentGroupName, UBSettings::trashedDocumentGroupNamePrefix + oldGroupName);
- UBPersistenceManager::persistenceManager()->persistDocumentMetadata(proxyTi->proxy());
-
- proxyTi->parent()->removeChild(proxyTi);
- mTrashTi->addChild(proxyTi);
- proxyTi->setFlags(proxyTi->flags() ^ Qt::ItemIsEditable);
+ moveDocumentToTrash(groupTi, proxyTi);
}
else
{
- // We have to physical delete document
- // No action with selection required - document from Trash cant be selected in Board
-
+ // We have to physically delete document
proxyTi->parent()->removeChild(proxyTi);
UBPersistenceManager::persistenceManager()->deleteDocument(proxyTi->proxy());
+
+ if (mTrashTi->childCount()==0)
+ selectDocument(NULL);
+ else
+ selectDocument(((UBDocumentProxyTreeItem*)mTrashTi->child(0))->proxy());
+ reloadThumbnails();
}
}
}
@@ -666,87 +756,7 @@ void UBDocumentController::deleteSelectedItem()
if(UBApplication::mainWindow->yesNoQuestion(tr("Remove Folder"), tr("Are you sure you want to remove the folder '%1' and all its content?").arg(groupTi->groupName())))
{
QApplication::setOverrideCursor(QCursor(Qt::WaitCursor));
-
- bool changeCurrentDocument = false;
- for (int i = 0; i < groupTi->childCount(); i++)
- {
- UBDocumentProxyTreeItem* proxyTi = dynamic_cast(groupTi->child(i));
- if (proxyTi && proxyTi->proxy() && proxyTi->proxy() == mBoardController->selectedDocument())
- {
- changeCurrentDocument = true;
- break;
- }
- }
-
- QList toBeDeleted;
-
- for (int i = 0; i < groupTi->childCount(); i++)
- {
- UBDocumentProxyTreeItem* proxyTi = dynamic_cast(groupTi->child(i));
- if (proxyTi && proxyTi->proxy())
- toBeDeleted << proxyTi;
- }
-
- for (int i = 0; i < toBeDeleted.count(); i++)
- {
- UBDocumentProxyTreeItem* proxyTi = toBeDeleted.at(i);
-
- showMessage(QString("Deleting %1").arg(proxyTi->proxy()->metaData(UBSettings::documentName).toString()));
- // Move document to trash
- QString oldGroupName = proxyTi->proxy()->metaData(UBSettings::documentGroupName).toString();
- proxyTi->proxy()->setMetaData(UBSettings::documentGroupName, UBSettings::trashedDocumentGroupNamePrefix + oldGroupName);
- UBPersistenceManager::persistenceManager()->persistDocumentMetadata(proxyTi->proxy());
-
- groupTi->removeChild(proxyTi);
- mTrashTi->addChild(proxyTi);
- proxyTi->setFlags(proxyTi->flags() ^ Qt::ItemIsEditable);
-
- showMessage(QString("%1 deleted").arg(groupTi->groupName()));
- }
-
- // dont remove default group
- if (!groupTi->isDefaultFolder())
- {
- int index = mDocumentUI->documentTreeWidget->indexOfTopLevelItem(groupTi);
-
- if (index >= 0)
- {
- mDocumentUI->documentTreeWidget->takeTopLevelItem(index);
- }
- }
-
- if (changeCurrentDocument)
- {
- bool documentFound = false;
- for (int i = 0; i < mDocumentUI->documentTreeWidget->topLevelItemCount(); i++)
- {
- QTreeWidgetItem* item = mDocumentUI->documentTreeWidget->topLevelItem(i);
- UBDocumentGroupTreeItem* groupItem = dynamic_cast(item);
- if (!groupItem->isTrashFolder() && groupItem != groupTi)
- {
- for(int j=0; jchildCount(); j++)
- {
- if (((UBDocumentProxyTreeItem*)groupItem->child(j))->proxy() != mBoardController->selectedDocument())
- {
- selectDocument(((UBDocumentProxyTreeItem*)groupItem->child(0))->proxy(), true);
- documentFound = true;
- break;
- }
- }
- }
- if (documentFound)
- break;
- }
- if (!documentFound)
- {
- UBDocumentProxy *document = UBPersistenceManager::persistenceManager()->createDocument( UBSettings::defaultDocumentGroupName );
- selectDocument(document, true);
- }
- }
-
-
- reloadThumbnails();
-
+ moveFolderToTrash(groupTi);
QApplication::restoreOverrideCursor();
}
}
diff --git a/src/document/UBDocumentController.h b/src/document/UBDocumentController.h
index d27ca0a6..ac8a113f 100644
--- a/src/document/UBDocumentController.h
+++ b/src/document/UBDocumentController.h
@@ -111,6 +111,9 @@ class UBDocumentController : public UBDocumentContainer
bool mToolsPalettePositionned;
UBDocumentGroupTreeItem* mTrashTi;
+ void moveDocumentToTrash(UBDocumentGroupTreeItem* groupTi, UBDocumentProxyTreeItem *proxyTi);
+ void moveFolderToTrash(UBDocumentGroupTreeItem* groupTi);
+
private slots:
void documentZoomSliderValueChanged (int value);
void loadDocumentProxies();
diff --git a/src/domain/UBGraphicsGroupContainerItem.cpp b/src/domain/UBGraphicsGroupContainerItem.cpp
index bed3b219..95b95af3 100644
--- a/src/domain/UBGraphicsGroupContainerItem.cpp
+++ b/src/domain/UBGraphicsGroupContainerItem.cpp
@@ -28,18 +28,12 @@ UBGraphicsGroupContainerItem::UBGraphicsGroupContainerItem(QGraphicsItem *parent
setUuid(QUuid::createUuid());
setData(UBGraphicsItemData::itemLayerType, QVariant(itemLayerType::ObjectItem)); //Necessary to set if we want z value to be assigned correctly
-
-
}
UBGraphicsGroupContainerItem::~UBGraphicsGroupContainerItem()
{
- foreach (QGraphicsItem *item, childItems())
- {
- removeFromGroup(item);
- if (item && item->scene())
- item->scene()->removeItem(item);
- }
+ if (mDelegate)
+ delete mDelegate;
}
void UBGraphicsGroupContainerItem::addToGroup(QGraphicsItem *item)
@@ -83,6 +77,10 @@ void UBGraphicsGroupContainerItem::addToGroup(QGraphicsItem *item)
QTransform newItemTransform(itemTransform);
item->setPos(mapFromItem(item, 0, 0));
+
+ item->scene()->removeItem(item);
+ if (corescene())
+ corescene()->removeItemFromDeletion(item);
item->setParentItem(this);
// removing position from translation component of the new transform
@@ -113,10 +111,12 @@ void UBGraphicsGroupContainerItem::removeFromGroup(QGraphicsItem *item)
{
if (!item) {
qDebug() << "can't specify the item because of the null pointer";
+ return;
}
- UBGraphicsScene *groupScene = scene();
- if (groupScene) {
+ UBCoreGraphicsScene *groupScene = corescene();
+ if (groupScene)
+ {
groupScene->addItemToDeletion(item);
}
@@ -170,9 +170,9 @@ void UBGraphicsGroupContainerItem::paint(QPainter *painter, const QStyleOptionGr
// }
}
-UBGraphicsScene *UBGraphicsGroupContainerItem::scene()
+UBCoreGraphicsScene *UBGraphicsGroupContainerItem::corescene()
{
- UBGraphicsScene *castScene = dynamic_cast(QGraphicsItem::scene());
+ UBCoreGraphicsScene *castScene = dynamic_cast(QGraphicsItem::scene());
return castScene;
}
@@ -218,15 +218,7 @@ void UBGraphicsGroupContainerItem::setUuid(const QUuid &pUuid)
void UBGraphicsGroupContainerItem::destroy() {
- UBGraphicsScene *groupScene = scene();
-
-
foreach (QGraphicsItem *item, childItems()) {
-
- if (groupScene) {
- groupScene->addItemToDeletion(item);
- }
-
pRemoveFromGroup(item);
item->setFlag(QGraphicsItem::ItemIsSelectable, true);
item->setFlag(QGraphicsItem::ItemIsFocusable, true);
@@ -235,6 +227,18 @@ void UBGraphicsGroupContainerItem::destroy() {
remove();
}
+void UBGraphicsGroupContainerItem::clearSource()
+{
+ foreach(QGraphicsItem *child, childItems())
+ {
+ UBGraphicsItem *item = dynamic_cast(child);
+ if (item)
+ {
+ item->clearSource();
+ }
+ }
+}
+
void UBGraphicsGroupContainerItem::mousePressEvent(QGraphicsSceneMouseEvent *event)
{
if (mDelegate->mousePressEvent(event)) {
@@ -327,6 +331,12 @@ void UBGraphicsGroupContainerItem::pRemoveFromGroup(QGraphicsItem *item)
item->setParentItem(newParent);
item->setPos(oldPos);
+ UBGraphicsScene *Scene = dynamic_cast(item->scene());
+ if (Scene)
+ {
+ Scene->addItem(item);
+ }
+
// removing position from translation component of the new transform
if (!item->pos().isNull())
itemTransform *= QTransform::fromTranslate(-item->x(), -item->y());
diff --git a/src/domain/UBGraphicsGroupContainerItem.h b/src/domain/UBGraphicsGroupContainerItem.h
index 535627eb..e8fa77eb 100644
--- a/src/domain/UBGraphicsGroupContainerItem.h
+++ b/src/domain/UBGraphicsGroupContainerItem.h
@@ -4,6 +4,7 @@
#include
#include "domain/UBItem.h"
+#include "frameworks/UBCoreGraphicsScene.h"
class UBGraphicsGroupContainerItem : public QGraphicsItem, public UBItem, public UBGraphicsItem
{
@@ -23,7 +24,7 @@ public:
virtual UBGraphicsItemDelegate* Delegate() const { return mDelegate;}
- virtual UBGraphicsScene* scene();
+ virtual UBCoreGraphicsScene *corescene();
virtual UBGraphicsGroupContainerItem *deepCopy() const;
virtual void copyItemParameters(UBItem *copy) const;
@@ -38,6 +39,8 @@ public:
virtual void setUuid(const QUuid &pUuid);
void destroy();
+ virtual void clearSource();
+
protected:
virtual void mousePressEvent(QGraphicsSceneMouseEvent *event);
virtual void mouseMoveEvent(QGraphicsSceneMouseEvent *event);
diff --git a/src/domain/UBGraphicsItemDelegate.cpp b/src/domain/UBGraphicsItemDelegate.cpp
index 4abeb1a2..6c0349e4 100644
--- a/src/domain/UBGraphicsItemDelegate.cpp
+++ b/src/domain/UBGraphicsItemDelegate.cpp
@@ -113,7 +113,6 @@ UBGraphicsItemDelegate::UBGraphicsItemDelegate(QGraphicsItem* pDelegated, QObjec
, mFlippable(false)
, mToolBarUsed(useToolBar)
{
- // NOOP
connect(UBApplication::boardController, SIGNAL(zoomChanged(qreal)), this, SLOT(onZoomChanged()));
}
@@ -167,7 +166,7 @@ void UBGraphicsItemDelegate::init()
UBGraphicsItemDelegate::~UBGraphicsItemDelegate()
{
- qDeleteAll(mButtons);
+ disconnect(UBApplication::boardController, SIGNAL(zoomChanged(qreal)), this, SLOT(onZoomChanged()));
// do not release mMimeData.
// the mMimeData is owned by QDrag since the setMimeData call as specified in the documentation
}
diff --git a/src/domain/UBGraphicsPolygonItem.cpp b/src/domain/UBGraphicsPolygonItem.cpp
index b21f2760..e5dd4fd7 100644
--- a/src/domain/UBGraphicsPolygonItem.cpp
+++ b/src/domain/UBGraphicsPolygonItem.cpp
@@ -142,14 +142,14 @@ QColor UBGraphicsPolygonItem::color() const
UBItem* UBGraphicsPolygonItem::deepCopy() const
-{
- UBGraphicsPolygonItem* copy = new UBGraphicsPolygonItem(polygon(), parentItem());
+{
+ UBGraphicsPolygonItem* copy = new UBGraphicsPolygonItem(polygon(), 0);
+ UBGraphicsStroke *stroke = new UBGraphicsStroke();
+
copyItemParameters(copy);
- copy->mOriginalLine = this->mOriginalLine;
- copy->mOriginalWidth = this->mOriginalWidth;
- copy->mIsNominalLine = this->mIsNominalLine;
+ copy->setStroke(stroke);
return copy;
}
@@ -160,17 +160,15 @@ void UBGraphicsPolygonItem::copyItemParameters(UBItem *copy) const
UBGraphicsPolygonItem *cp = dynamic_cast(copy);
if (cp)
{
- cp->mOriginalLine = QLineF();
- cp->mOriginalWidth = -1;
- cp->mIsNominalLine = false;
+ cp->mOriginalLine = this->mOriginalLine;
+ cp->mOriginalWidth = this->mOriginalWidth;
+ cp->mIsNominalLine = this->mIsNominalLine;
- cp->setStroke(this->stroke());
- cp->setStrokesGroup(this->strokesGroup());
+ cp->setTransform(transform());
cp->setBrush(this->brush());
cp->setPen(this->pen());
cp->mHasAlpha = this->mHasAlpha;
-
cp->setColorOnDarkBackground(this->colorOnDarkBackground());
cp->setColorOnLightBackground(this->colorOnLightBackground());
diff --git a/src/domain/UBGraphicsScene.cpp b/src/domain/UBGraphicsScene.cpp
index 9a89e96b..ea3666df 100644
--- a/src/domain/UBGraphicsScene.cpp
+++ b/src/domain/UBGraphicsScene.cpp
@@ -263,7 +263,6 @@ UBGraphicsScene::UBGraphicsScene(UBDocumentProxy* parent)
, mCrossedBackground(false)
, mIsDesktopMode(false)
, mZoomFactor(1)
- , mIsModified(true)
, mBackgroundObject(0)
, mPreviousWidth(0)
, mInputDeviceIsPressed(false)
@@ -305,7 +304,10 @@ UBGraphicsScene::~UBGraphicsScene()
{
if (mCurrentStroke)
if (mCurrentStroke->polygons().empty())
+ {
delete mCurrentStroke;
+ mCurrentStroke = NULL;
+ }
if (mZLayerController)
delete mZLayerController;
@@ -433,6 +435,11 @@ bool UBGraphicsScene::inputDevicePress(const QPointF& scenePos, const qreal& pre
}
}
+ if (mCurrentStroke && mCurrentStroke->polygons().empty()){
+ delete mCurrentStroke;
+ mCurrentStroke = NULL;
+ }
+
return accepted;
}
@@ -474,6 +481,10 @@ bool UBGraphicsScene::inputDeviceMove(const QPointF& scenePos, const qreal& pres
UBCoreGraphicsScene::removeItemFromDeletion(mpLastPolygon);
mAddedItems.remove(mpLastPolygon);
mCurrentStroke->remove(mpLastPolygon);
+ if (mCurrentStroke->polygons().empty()){
+ delete mCurrentStroke;
+ mCurrentStroke = NULL;
+ }
removeItem(mpLastPolygon);
mPreviousPolygonItems.removeAll(mpLastPolygon);
}
@@ -1060,12 +1071,9 @@ void UBGraphicsScene::clearItemsAndAnnotations()
QSet emptyList;
QSet removedItems;
- QListIterator itItems(mFastAccessItems);
-
- while (itItems.hasNext())
+ QList sceneItems = items();
+ foreach(QGraphicsItem* item, sceneItems)
{
- QGraphicsItem* item = itItems.next();
-
if(!mTools.contains(item) && !isBackgroundObject(item))
{
removeItem(item);
@@ -1091,21 +1099,17 @@ void UBGraphicsScene::clearItems()
QSet emptyList;
QSet removedItems;
- QListIterator itItems(mFastAccessItems);
-
- while (itItems.hasNext())
+ QList sceneItems = items();
+ foreach(QGraphicsItem* item, sceneItems)
{
- QGraphicsItem* item = itItems.next();
+ bool isGroup = qgraphicsitem_cast(item) != NULL;
+ bool isPolygon = qgraphicsitem_cast(item) != NULL;
+ bool isStrokesGroup = qgraphicsitem_cast(item) != NULL;
- if (!item->parentItem())
+ if(!isGroup && !isPolygon && !isStrokesGroup && !mTools.contains(item) && !isBackgroundObject(item))
{
- UBGraphicsPolygonItem* pi = qgraphicsitem_cast(item);
-
- if(!pi && !mTools.contains(item) && !isBackgroundObject(item))
- {
- removeItem(item);
- removedItems << item;
- }
+ removeItem(item);
+ removedItems << item;
}
}
@@ -1126,11 +1130,9 @@ void UBGraphicsScene::clearAnnotations()
QSet emptyList;
QSet removedItems;
- QListIterator itItems(mFastAccessItems);
-
- while (itItems.hasNext())
+ QList sceneItems = items();
+ foreach(QGraphicsItem* item, sceneItems)
{
- QGraphicsItem* item = itItems.next();
UBGraphicsStrokesGroup* pi = qgraphicsitem_cast(item);
if (pi)
{
@@ -1142,7 +1144,6 @@ void UBGraphicsScene::clearAnnotations()
// force refresh, QT is a bit lazy and take a lot of time (nb item ^2 ?) to trigger repaint
update(sceneRect());
-
if (enableUndoRedoStack) { //should be deleted after scene own undo stack implemented
UBGraphicsItemUndoCommand* uc = new UBGraphicsItemUndoCommand(this, removedItems, emptyList);
UBApplication::undoStack->push(uc);
@@ -1356,6 +1357,7 @@ UBGraphicsW3CWidgetItem* UBGraphicsScene::addOEmbed(const QUrl& pContentUrl, con
UBGraphicsGroupContainerItem *UBGraphicsScene::createGroup(QList items)
{
UBGraphicsGroupContainerItem *groupItem = new UBGraphicsGroupContainerItem();
+ addItem(groupItem);
foreach (QGraphicsItem *item, items) {
if (item->type() == UBGraphicsGroupContainerItem::Type) {
@@ -1366,13 +1368,14 @@ UBGraphicsGroupContainerItem *UBGraphicsScene::createGroup(QListaddToGroup(chItem);
+ mFastAccessItems.removeAll(chItem);
}
} else {
groupItem->addToGroup(item);
+ mFastAccessItems.removeAll(item);
}
}
- addItem(groupItem);
groupItem->setVisible(true);
groupItem->setFocus();
@@ -1389,6 +1392,15 @@ UBGraphicsGroupContainerItem *UBGraphicsScene::createGroup(QListchildItems().count(); i++)
+ {
+ QGraphicsItem *it = qgraphicsitem_cast(groupItem->childItems().at(i));
+ if (it)
+ {
+ mFastAccessItems.removeAll(it);
+ }
+ }
+
groupItem->setVisible(true);
groupItem->setFocus();
@@ -1557,7 +1569,6 @@ UBGraphicsTextItem *UBGraphicsScene::addTextHtml(const QString &pString, const Q
void UBGraphicsScene::addItem(QGraphicsItem* item)
{
- setModified(true);
UBCoreGraphicsScene::addItem(item);
UBGraphicsItem::assignZValue(item, mZLayerController->generateZLevel(item));
@@ -1570,8 +1581,6 @@ void UBGraphicsScene::addItem(QGraphicsItem* item)
void UBGraphicsScene::addItems(const QSet& items)
{
- setModified(true);
-
foreach(QGraphicsItem* item, items) {
UBCoreGraphicsScene::addItem(item);
UBGraphicsItem::assignZValue(item, mZLayerController->generateZLevel(item));
@@ -1584,7 +1593,7 @@ void UBGraphicsScene::addItems(const QSet& items)
void UBGraphicsScene::removeItem(QGraphicsItem* item)
{
- setModified(true);
+ item->setSelected(false);
UBCoreGraphicsScene::removeItem(item);
UBApplication::boardController->freezeW3CWidget(item, true);
@@ -1596,8 +1605,6 @@ void UBGraphicsScene::removeItem(QGraphicsItem* item)
void UBGraphicsScene::removeItems(const QSet& items)
{
- setModified(true);
-
foreach(QGraphicsItem* item, items)
UBCoreGraphicsScene::removeItem(item);
@@ -1755,7 +1762,6 @@ void UBGraphicsScene::addRuler(QPointF center)
addItem(ruler);
ruler->setVisible(true);
- setModified(true);
}
void UBGraphicsScene::addProtractor(QPointF center)
@@ -1773,7 +1779,6 @@ void UBGraphicsScene::addProtractor(QPointF center)
protractor->moveBy(center.x() - itemSceneCenter.x(), center.y() - itemSceneCenter.y());
protractor->setVisible(true);
- setModified(true);
}
void UBGraphicsScene::addTriangle(QPointF center)
@@ -1791,7 +1796,6 @@ void UBGraphicsScene::addTriangle(QPointF center)
triangle->moveBy(center.x() - itemSceneCenter.x(), center.y() - itemSceneCenter.y());
triangle->setVisible(true);
- setModified(true);
}
void UBGraphicsScene::addMagnifier(UBMagnifierParams params)
@@ -1850,6 +1854,7 @@ void UBGraphicsScene::moveMagnifier()
{
QPoint magnifierPos = QPoint(magniferControlViewWidget->pos().x() + magniferControlViewWidget->size().width() / 2, magniferControlViewWidget->pos().y() + magniferControlViewWidget->size().height() / 2 );
moveMagnifier(magnifierPos, true);
+ setModified(true);
}
}
@@ -1882,6 +1887,7 @@ void UBGraphicsScene::moveMagnifier(QPoint newPos, bool forceGrab)
void UBGraphicsScene::closeMagnifier()
{
DisposeMagnifierQWidgets();
+ setModified(true);
}
void UBGraphicsScene::zoomInMagnifier()
@@ -1899,6 +1905,7 @@ void UBGraphicsScene::zoomOutMagnifier()
{
magniferControlViewWidget->setZoom(magniferControlViewWidget->params.zoom - 0.5);
magniferDisplayViewWidget->setZoom(magniferDisplayViewWidget->params.zoom - 0.5);
+ setModified(true);
}
}
@@ -1910,6 +1917,7 @@ void UBGraphicsScene::resizedMagnifier(qreal newPercent)
magniferControlViewWidget->grabPoint();
magniferDisplayViewWidget->setSize(newPercent);
magniferDisplayViewWidget->grabPoint();
+ setModified(true);
}
}
@@ -1925,7 +1933,6 @@ void UBGraphicsScene::addCompass(QPointF center)
compass->setData(UBGraphicsItemData::ItemLayerType, QVariant(UBItemLayerType::Tool));
compass->setVisible(true);
- setModified(true);
}
void UBGraphicsScene::addCache()
@@ -1955,7 +1962,6 @@ void UBGraphicsScene::addMask(const QPointF ¢er)
curtain->setRect(rect);
curtain->setVisible(true);
curtain->setSelected(true);
- setModified(true);
}
void UBGraphicsScene::setRenderingQuality(UBItem::RenderingQuality pRenderingQuality)
@@ -2205,7 +2211,6 @@ void UBGraphicsScene::keyReleaseEvent(QKeyEvent * keyEvent)
default:
{
- item->setSelected(false);
UBGraphicsItem *ubgi = dynamic_cast(item);
if (0 != ubgi)
ubgi->remove();
@@ -2267,6 +2272,11 @@ void UBGraphicsScene::setToolCursor(int tool)
{
deselectAllItems();
}
+
+ if (mCurrentStroke && mCurrentStroke->polygons().empty()){
+ delete mCurrentStroke;
+ }
+ mCurrentStroke = NULL;
}
void UBGraphicsScene::initStroke(){
diff --git a/src/domain/UBGraphicsScene.h b/src/domain/UBGraphicsScene.h
index 738bd429..6f8c8def 100644
--- a/src/domain/UBGraphicsScene.h
+++ b/src/domain/UBGraphicsScene.h
@@ -179,16 +179,6 @@ class UBGraphicsScene: public UBCoreGraphicsScene, public UBItem
bool isEmpty() const;
- bool isModified() const
- {
- return mIsModified;
- }
-
- void setModified(bool pModified)
- {
- mIsModified = pModified;
- }
-
void setDocument(UBDocumentProxy* pDocument);
UBDocumentProxy* document() const
@@ -380,8 +370,6 @@ public slots:
bool mIsDesktopMode;
qreal mZoomFactor;
- bool mIsModified;
-
QGraphicsItem* mBackgroundObject;
QPointF mPreviousPoint;
diff --git a/src/domain/UBGraphicsStrokesGroup.cpp b/src/domain/UBGraphicsStrokesGroup.cpp
index 6da869a1..e9993375 100644
--- a/src/domain/UBGraphicsStrokesGroup.cpp
+++ b/src/domain/UBGraphicsStrokesGroup.cpp
@@ -113,29 +113,30 @@ void UBGraphicsStrokesGroup::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
UBItem* UBGraphicsStrokesGroup::deepCopy() const
{
- UBGraphicsStrokesGroup* copy = new UBGraphicsStrokesGroup();
+ UBGraphicsStrokesGroup* copy = new UBGraphicsStrokesGroup();
-
- QList chl = childItems();
+ QList chl = childItems();
foreach(QGraphicsItem *child, chl)
{
UBGraphicsPolygonItem *polygon = dynamic_cast(child);
if (polygon)
+ {
copy->addToGroup(dynamic_cast(polygon->deepCopy()));
+ polygon->setStrokesGroup(copy);
+ }
}
copyItemParameters(copy);
- return copy;
+ return copy;
}
void UBGraphicsStrokesGroup::copyItemParameters(UBItem *copy) const
{
UBGraphicsStrokesGroup *cp = dynamic_cast(copy);
{
- cp->setPos(this->pos());
+ cp->setTransform(transform());
- cp->setTransform(this->transform());
cp->setFlag(QGraphicsItem::ItemIsMovable, true);
cp->setFlag(QGraphicsItem::ItemIsSelectable, true);
cp->setData(UBGraphicsItemData::ItemLayerType, this->data(UBGraphicsItemData::ItemLayerType));
diff --git a/src/frameworks/UBCoreGraphicsScene.cpp b/src/frameworks/UBCoreGraphicsScene.cpp
index fd4948ec..b39eef0d 100644
--- a/src/frameworks/UBCoreGraphicsScene.cpp
+++ b/src/frameworks/UBCoreGraphicsScene.cpp
@@ -23,6 +23,7 @@
UBCoreGraphicsScene::UBCoreGraphicsScene(QObject * parent)
: QGraphicsScene ( parent )
+ , mIsModified(true)
{
//NOOP
}
@@ -30,27 +31,40 @@ UBCoreGraphicsScene::UBCoreGraphicsScene(QObject * parent)
UBCoreGraphicsScene::~UBCoreGraphicsScene()
{
//we must delete removed items that are no more in any scene
- foreach (const QGraphicsItem* item, mItemsToDelete)
+ //at groups deleting some items can be added to mItemsToDelete, so we need to use iterators.
+ if (mItemsToDelete.count())
{
- if (item->scene() == NULL || item->scene() == this)
+ QSet::iterator it = mItemsToDelete.begin();
+ QGraphicsItem* item = *it;
+ do
{
- delete item;
- }
+ item = *it;
+ if (item && (item->scene() == NULL || item->scene() == this))
+ {
+ mItemsToDelete.remove(*it);
+ delete item;
+ }
+
+ it = mItemsToDelete.begin();
+
+ }while(mItemsToDelete.count());
}
}
void UBCoreGraphicsScene::addItem(QGraphicsItem* item)
{
+ addItemToDeletion(item);
+
if (item->type() == UBGraphicsGroupContainerItem::Type && item->childItems().count()) {
foreach (QGraphicsItem *curItem, item->childItems()) {
removeItemFromDeletion(curItem);
}
}
-
- mItemsToDelete << item;
-
+
if (item->scene() != this)
QGraphicsScene::addItem(item);
+
+ setModified(true);
}
@@ -59,27 +73,16 @@ void UBCoreGraphicsScene::removeItem(QGraphicsItem* item, bool forceDelete)
QGraphicsScene::removeItem(item);
if (forceDelete)
{
- mItemsToDelete.remove(item);
- delete item;
- item = 0;
+ deleteItem(item);
}
+ setModified(true);
}
bool UBCoreGraphicsScene::deleteItem(QGraphicsItem* item)
{
if(mItemsToDelete.contains(item))
{
- UBGraphicsItem* item_casted = 0;
- switch (item->type())
- {
- case UBGraphicsMediaItem::Type:
- item_casted = dynamic_cast(item);
- break;
- case UBGraphicsW3CWidgetItem::Type:
- item_casted = dynamic_cast(item);
- break;
- }
-
+ UBGraphicsItem *item_casted = dynamic_cast(item);
if (0 != item_casted)
item_casted->clearSource();
diff --git a/src/frameworks/UBCoreGraphicsScene.h b/src/frameworks/UBCoreGraphicsScene.h
index d518db4c..19ed9da9 100644
--- a/src/frameworks/UBCoreGraphicsScene.h
+++ b/src/frameworks/UBCoreGraphicsScene.h
@@ -33,8 +33,21 @@ class UBCoreGraphicsScene : public QGraphicsScene
void removeItemFromDeletion(QGraphicsItem* item);
void addItemToDeletion(QGraphicsItem *item);
+ bool isModified() const
+ {
+ return mIsModified;
+ }
+
+ void setModified(bool pModified)
+ {
+ mIsModified = pModified;
+ }
+
+
private:
QSet mItemsToDelete;
+
+ bool mIsModified;
};
#endif /* UBCOREGRAPHICSSCENE_H_ */
diff --git a/src/gui/UBPropertyPalette.cpp b/src/gui/UBPropertyPalette.cpp
index 8d587c99..643f87a7 100644
--- a/src/gui/UBPropertyPalette.cpp
+++ b/src/gui/UBPropertyPalette.cpp
@@ -25,6 +25,7 @@ UBPropertyPalette::UBPropertyPalette(QWidget *parent, const char *name):UBAction
{
setObjectName(name);
mbGrip = false;
+ setMaximumHeight(MAX_HEIGHT);
}
/**
@@ -35,6 +36,7 @@ UBPropertyPalette::UBPropertyPalette(QWidget *parent, const char *name):UBAction
UBPropertyPalette::UBPropertyPalette(Qt::Orientation orientation, QWidget *parent):UBActionPalette(orientation, parent)
{
mbGrip = false;
+ setMaximumHeight(MAX_HEIGHT);
}
/**
diff --git a/src/gui/UBPropertyPalette.h b/src/gui/UBPropertyPalette.h
index 777e976e..47bacf13 100644
--- a/src/gui/UBPropertyPalette.h
+++ b/src/gui/UBPropertyPalette.h
@@ -20,6 +20,8 @@
#include "UBActionPalette.h"
+#define MAX_HEIGHT 20
+
class UBPropertyPalette : public UBActionPalette
{
Q_OBJECT
diff --git a/src/gui/UBThumbnailWidget.cpp b/src/gui/UBThumbnailWidget.cpp
index 24f7442f..3057761b 100644
--- a/src/gui/UBThumbnailWidget.cpp
+++ b/src/gui/UBThumbnailWidget.cpp
@@ -12,11 +12,13 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see .
*/
+#include
#include
#include
#include "UBThumbnailWidget.h"
#include "UBRubberBand.h"
+#include "UBMainWindow.h"
#include "board/UBBoardController.h"
@@ -858,7 +860,9 @@ void UBSceneThumbnailNavigPixmap::updateButtonsState()
void UBSceneThumbnailNavigPixmap::deletePage()
{
- UBApplication::boardController->deleteScene(sceneIndex());
+ if(UBApplication::mainWindow->yesNoQuestion(QObject::tr("Remove Page"), QObject::tr("Are you sure you want to remove 1 page from the selected document '%0'?").arg(UBApplication::documentController->selectedDocument()->metaData(UBSettings::documentName).toString()))){
+ UBApplication::boardController->deleteScene(sceneIndex());
+ }
}
void UBSceneThumbnailNavigPixmap::duplicatePage()