From 505ca347afe1aca13e68823df05322364150f81e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Fauconnier?= Date: Mon, 2 Nov 2020 11:05:10 +0100 Subject: [PATCH] renamed and moved XPDF zoom constants to make them more readable and open to further development --- src/pdf/XPDFRenderer.cpp | 15 ++++----------- src/pdf/XPDFRenderer.h | 9 +++++++++ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/pdf/XPDFRenderer.cpp b/src/pdf/XPDFRenderer.cpp index 92a6e1e6..e128b33b 100644 --- a/src/pdf/XPDFRenderer.cpp +++ b/src/pdf/XPDFRenderer.cpp @@ -42,13 +42,6 @@ QAtomicInt XPDFRenderer::sInstancesCount = 0; -namespace constants{ - const double mode1_zoomFactor = 3.0; - const double mode2_zoomFactorStage1 = 2.5; - const double mode2_zoomFactorStage2 = 5.0; - const double mode2_zoomFactorStage3 = 10.0; -} - XPDFRenderer::XPDFRenderer(const QString &filename, bool importingFile) : mpSplashBitmapHistorical(nullptr), mSplashHistorical(nullptr), mDocument(nullptr) { @@ -57,12 +50,12 @@ XPDFRenderer::XPDFRenderer(const QString &filename, bool importingFile) : break; case 1: // Render a single image, degradated quality when zoomed big. default: - m_pdfZoomCache.push_back(constants::mode1_zoomFactor); + m_pdfZoomCache.push_back(XPDFRendererZoomFactor::mode1_zoomFactor); break; case 2: // Render three images, optimal quality all the time. - m_pdfZoomCache.push_back(constants::mode2_zoomFactorStage1); - m_pdfZoomCache.push_back(constants::mode2_zoomFactorStage2); - m_pdfZoomCache.push_back(constants::mode2_zoomFactorStage3); + m_pdfZoomCache.push_back(XPDFRendererZoomFactor::mode2_zoomFactorStage1); + m_pdfZoomCache.push_back(XPDFRendererZoomFactor::mode2_zoomFactorStage2); + m_pdfZoomCache.push_back(XPDFRendererZoomFactor::mode2_zoomFactorStage3); break; } diff --git a/src/pdf/XPDFRenderer.h b/src/pdf/XPDFRenderer.h index 43357b01..4ac3f9aa 100644 --- a/src/pdf/XPDFRenderer.h +++ b/src/pdf/XPDFRenderer.h @@ -51,6 +51,15 @@ class PDFDoc; + +namespace XPDFRendererZoomFactor +{ + const double mode1_zoomFactor = 3.0; + const double mode2_zoomFactorStage1 = 2.5; + const double mode2_zoomFactorStage2 = 5.0; + const double mode2_zoomFactorStage3 = 10.0; +} + class XPDFRenderer : public PDFRenderer { Q_OBJECT