From ab51a2eb24e75ae79bf3e3213ca0d8a80a6e97bb Mon Sep 17 00:00:00 2001 From: "Victor \"multun\" Collod" Date: Sun, 26 Apr 2020 19:35:55 -0700 Subject: [PATCH] fix uninitialized variable uses I did a valgrind run to try and figure out why it OpenBoard crashes from time to time, and found these two uninitialized variable uses. --- src/document/UBDocumentController.cpp | 1 + src/domain/UBGraphicsStrokesGroup.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/document/UBDocumentController.cpp b/src/document/UBDocumentController.cpp index 03d676fb..e01611d8 100644 --- a/src/document/UBDocumentController.cpp +++ b/src/document/UBDocumentController.cpp @@ -345,6 +345,7 @@ UBDocumentTreeNode *UBDocumentTreeNode::previousSibling() UBDocumentTreeModel::UBDocumentTreeModel(QObject *parent) : QAbstractItemModel(parent) , mRootNode(0) + , mCurrentNode(nullptr) { UBDocumentTreeNode *rootNode = new UBDocumentTreeNode(UBDocumentTreeNode::Catalog, "root"); diff --git a/src/domain/UBGraphicsStrokesGroup.cpp b/src/domain/UBGraphicsStrokesGroup.cpp index 8ce08a2e..75d04dad 100644 --- a/src/domain/UBGraphicsStrokesGroup.cpp +++ b/src/domain/UBGraphicsStrokesGroup.cpp @@ -35,7 +35,10 @@ #include "core/memcheck.h" UBGraphicsStrokesGroup::UBGraphicsStrokesGroup(QGraphicsItem *parent) - :QGraphicsItemGroup(parent), UBGraphicsItem() + : QGraphicsItemGroup(parent) + , UBGraphicsItem() + , debugTextEnabled(false) // set to true to get a graphical display of strokes' Z-levels + , mDebugText(nullptr) { setDelegate(new UBGraphicsItemDelegate(this, 0, GF_COMMON | GF_RESPECT_RATIO @@ -49,9 +52,6 @@ UBGraphicsStrokesGroup::UBGraphicsStrokesGroup(QGraphicsItem *parent) setFlag(QGraphicsItem::ItemSendsGeometryChanges, true); setFlag(QGraphicsItem::ItemIsSelectable, true); setFlag(QGraphicsItem::ItemIsMovable, true); - - mDebugText = NULL; - debugTextEnabled = false; // set to true to get a graphical display of strokes' Z-levels } UBGraphicsStrokesGroup::~UBGraphicsStrokesGroup()