7a4e9d2e83
Removed UBGraphicsPolygonItem::shape()
...
Long version:
UBGraphicsPolygonItem::shape() sometimes caused OpenBoard to crash due to
inifinite recursion. This is easily replicated by trying to use the
highlighting tool.
The reason is: shape() calls boundingRect(); this function's definition is:
QRectF QGraphicsPolygonItem::boundingRect() const
{
Q_D(const QGraphicsPolygonItem);
if (d->boundingRect.isNull()) {
qreal pw = pen().style() == Qt::NoPen ? qreal(0) : pen().widthF();
if (pw == 0.0)
d->boundingRect = d->polygon.boundingRect();
else
d->boundingRect = shape().controlPointRect();
}
return d->boundingRect;
}
In the case where pw != 0, the shape() function is called. However, it
is shape() from the derived class, not the base class, which is called.
In other words, UBGraphicsPolygonItem::shape() is called rather than
QGraphicsPolygonItem::shape().
This means that boundingRect() is called again from within shape(), and
so on, causing the program to crash.
The fix was simply to remove UBGraphicsPolygonItem::shape(), as it
appears to provide the same (or very similar) functionality to that of
the base class's shape() function.
In case this shape() function actually is needed, another workaround
should be implemented to prevent this infinite recursion.
9 years ago
72d43788da
Corrected signal/slot connection (signal function header changed)
9 years ago
5d46891984
Removed Linux-specific define (didn't work; the function wasn't defined when compiling on Linux, for some reason)
9 years ago
1727264325
Removed obsolete setGraphicsSystem call (may break functionality; if so, use QPA framework)
9 years ago
89c0813e52
Added missing includes
9 years ago
cdb56333f3
Replaced Phonon with QtMultimedia
9 years ago
bedf11cc2d
Updated Q_WS_* env variables.
...
Q_WS_MACX -> Q_OS_OSX
Q_WS_MAC -> Q_OS_OSX
Q_WS_WIN -> Q_OS_WIN
Q_WS_X11 -> Q_OS_LINUX
9 years ago
55dd0450ff
More minor updates (function names changed, includes added, etc)
9 years ago
b78cc08318
Added loadAcquire() to get int value of QAtomicInt variables. (Was previously done automatically with the operatorint() of QAtomicInt)
9 years ago
4a7854e03b
Corrected paths for inclusion of pdf-merger files into project (relative paths in .pri didn't work)
9 years ago
a2c2c2c4e1
Updated geometric functions (transform, scale, rotate) for Qt5 comp.
9 years ago
4b15c535ec
minor compatibility updates (added missing headers, simple function name changes etc)
9 years ago
a060459e1a
Removed obsolete QHttp functions; added new checkUpdate() and associated functions
9 years ago
087738d5c0
Minor updates (includes, changes in function names)
9 years ago
1b4cca3a39
Updated connect functions
9 years ago
2484e96bcf
Changes to message handler function; removal of obsolete setCodecForTr functions
9 years ago
4a99febbb0
added 'supportedDragActions' function to replace functionality provided by 'setSupportedDragActions' function (obsolete)
9 years ago
c49d4ed7da
Replaced QDesktopServices (obsolete) with QStandardPaths
9 years ago
26f6de7851
Minor compatibility updates (strings etc; missing includes)
9 years ago
d97feb57ef
Added includes for Qt5 compatibility
9 years ago
92a07e8243
added includes for Qt5 compatibility
9 years ago
42eb05560b
Removed deprecated QPlastiqueStyle. Replaced by stock Fusion style (new in Qt5). Change this to keep the custom look defined in UBStyle?
9 years ago
385ac60ccf
added includes for Qt5 compatibility
9 years ago
2ee0eb793f
Mac Os X : Defined variable for conditional build
10 years ago
a9db6c44b0
introduced the possibility to choose the wanted on screen keyboard
10 years ago
4781a9bfc2
hack for onboard
10 years ago
7cd7af2de4
when page is deleted the pictures are deleted too
10 years ago
e51a783b74
fixed dnd on document mode
10 years ago
dd6a41fde3
fixed duplication issue
10 years ago
8f89afbd54
fixed issue of images imported on document mode with the import button
10 years ago
9df8c0f823
removed bad fix. Duplication of imported image
10 years ago
5cd0fc1d4d
tutorial url as app paremeter
10 years ago
a2eb4c06c0
Fixed bug. On import action the image is immediately stored into the document folder
10 years ago
8713dc3bcb
removed monitor for document directory
10 years ago
cff1849fd0
ready for release
11 years ago
e516d2e9df
mac os fix
11 years ago
6226ad20b7
removed copy of hidden graphics objects
11 years ago
fcae8c57c9
fixed eraser issue on strokes
11 years ago
87c48bbbf8
removed duplicated code
11 years ago
ee069c75ef
fixed with pixmap and svg not saved on disk when added from a capture
11 years ago
bddb4db2b8
cosmetics
11 years ago
f84d204226
removed hack and correct duplication on a group
11 years ago
aaa09c9921
document removed if it contains only <<structural>> QGraphicsItems
11 years ago
6d7350445f
workaround for issue related to the group duplication
11 years ago
1e6e64c9ec
removed debug logs
11 years ago
4fbbdba82e
14.04 ubuntu fix
11 years ago
5db7791042
group added on scene once
11 years ago
552df68781
fixed stroke transformation
11 years ago
5c89e8a752
added comment
11 years ago
92c4312981
removed unused code
11 years ago
Craig Watson
Claudio Valerio
Claudio Valerio
root
Claudio Valerio