some cleaning (code and warning)

src/adaptors/publishing/UBDocumentPublisher.h

@@ -42,6 +42,8 @@ private slots:
 
 private:
 
+    UBDocumentProxy *mSourceDocument;
+    UBDocumentProxy *mPublishingDocument;
     void init();
     void sendUbw();
     QString getBase64Of(QString stringToEncode);
@@ -58,8 +60,5 @@ private:
     void buildUbwFile();
     QString mTmpZipFile;
 
-    UBDocumentProxy *mSourceDocument;
-    UBDocumentProxy *mPublishingDocument;
-
 };
 #endif // UBDOCUMENTPUBLISHER_H

src/board/UBDrawingController.cpp

@@ -27,9 +27,10 @@ UBDrawingController* UBDrawingController::drawingController()
 
 UBDrawingController::UBDrawingController(QObject * parent)
     : QObject(parent)
+    , mActiveRuler(NULL)
     , mStylusTool((UBStylusTool::Enum)-1)
     , mLatestDrawingTool((UBStylusTool::Enum)-1)
-	, mActiveRuler(NULL)
+
 {
     connect(UBSettings::settings(), SIGNAL(colorContextChanged()), this, SIGNAL(colorPaletteChanged()));
 

src/core/UBApplicationController.cpp

@@ -50,12 +50,13 @@ UBApplicationController::UBApplicationController(UBBoardView *pControlView, UBBo
     , mControlView(pControlView)
     , mDisplayView(pDisplayView)
     , mMirror(0)
+    , mFtp(0)
     , mMainMode(Board)
     , mDisplayManager(0)
     , mAutomaticCheckForUpdates(false)
     , mCheckingForUpdates(false)
     , mIsShowingDesktop(false)
-	, mFtp(0)
+
 {
     mDisplayManager = new UBDisplayManager(this);
 

src/core/UBApplicationController.h

@@ -24,8 +24,7 @@ class UBApplicationController : public QObject
 
     public:
 
-        UBApplicationController(UBBoardView *pControlView, UBBoardView *pDisplayView,
+        UBApplicationController(UBBoardView *pControlView, UBBoardView *pDisplayView, UBMainWindow *pMainWindow, QObject* parent = 0);
-                UBMainWindow *pMainWindow, QObject* parent = 0);
         virtual ~UBApplicationController();
 
         int initialHScroll() { return mInitialHScroll; }

src/core/UBSceneCache.h

@@ -7,7 +7,7 @@
 
 class UBDocumentProxy;
 class UBGraphicsScene;
-class UBGraphicsScene::SceneViewState;
+class UBGraphicsScene;
 
 class UBSceneCacheID
 {

src/frameworks/UBPlatformUtils_linux.cpp

@@ -56,6 +56,8 @@ QString UBPlatformUtils::preferredLanguage()
 void UBPlatformUtils::runInstaller(const QString &installerFilePath)
 {
     // TODO UB 4.x - auto update & installer are deactivated on Linux
+    Q_UNUSED(installerFilePath);
+
 }
 
 void UBPlatformUtils::bringPreviousProcessToFront()
@@ -77,6 +79,8 @@ QString UBPlatformUtils::computerName()
 
 void UBPlatformUtils::setWindowNonActivableFlag(QWidget* widget, bool nonAcivable)
 {
+    Q_UNUSED(widget);
+    Q_UNUSED(nonAcivable);
 }
 
 
@@ -84,6 +88,7 @@ void UBPlatformUtils::setWindowNonActivableFlag(QWidget* widget, bool nonAcivabl
 void UBPlatformUtils::setDesktopMode(bool desktop)
 {
     // NOOP
+    Q_UNUSED(desktop);
 }
 
 const KEYBT ENGLISH_LOCALE[] = {

src/gui/UBFloatingPalette.cpp

@@ -12,8 +12,8 @@
 
 UBFloatingPalette::UBFloatingPalette(Qt::Corner position, QWidget *parent)
     : QWidget(parent, parent ? Qt::Widget : Qt::Tool | (Qt::FramelessWindowHint | Qt::WindowStaysOnTopHint | Qt::X11BypassWindowManagerHint))
-    , mIsMoving(false)
     , mCustomPosition(false)
+    , mIsMoving(false)
     , mCanBeMinimized(false)
     , mMinimizedLocation(eMinimizedLocation_None)
     , mDefaultPosition(position)

src/gui/UBKeyboardPalette.cpp

@@ -309,9 +309,9 @@ void  UBKeyboardPalette::paintEvent( QPaintEvent* event)
 
 UBKeyboardButton::UBKeyboardButton(UBKeyboardPalette* parent)
         :QWidget(parent),
+        keyboard(parent),
         bFocused(false),
-	bPressed(false),
+        bPressed(false)
-	keyboard(parent)
 {
     setCursor(Qt::PointingHandCursor);
 }

src/gui/UBKeyboardPalette_linux.cpp

@@ -41,7 +41,7 @@ void x11SendKey(Display *display, int keyCode, int modifiers)
 
 // Get the root window for the current display.
    Window winRoot = XDefaultRootWindow(display);
-   if (winRoot==NULL)
+   if (winRoot==0)
        return;
 
 // Find the window which has the current keyboard focus.

src/gui/UBLibNavigatorWidget.cpp

@@ -69,16 +69,6 @@ UBLibNavigatorWidget::UBLibNavigatorWidget(QWidget *parent, const char *name):QW
  */
 UBLibNavigatorWidget::~UBLibNavigatorWidget()
 {
-    //if(NULL != mLayout)
-    //{
-    //    delete mLayout;
-    //    mLayout = NULL;
-    //}
-    //if(NULL != mLibWidget)
-    //{
-    //    delete mLibWidget;
-    //    mLibWidget = NULL;
-    //}
     if(NULL != mPathViewer)
     {
         delete mPathViewer;
@@ -99,7 +89,7 @@ UBLibNavigatorWidget::~UBLibNavigatorWidget()
 void UBLibNavigatorWidget::dropMe(const QMimeData *_data)
 {
     // Forward the mime data to the library widget
-
+    Q_UNUSED(_data);
 }
 
 /**