exported all the logic for page actions on UBDocumentController

src/document/UBDocumentController.cpp

@@ -1645,3 +1645,29 @@ int UBDocumentController::getSelectedItemIndex()
     }
     else return -1;
 }
+
+bool UBDocumentController::pageCanBeMovedUp(int page)
+{
+	if(UBSettings::settings()->teacherGuidePageZeroActivated->get().toBool())
+		return page >= 2;
+	else
+		return page >= 1;
+}
+
+bool UBDocumentController::pageCanBeMovedDown(int page)
+{
+	if(UBSettings::settings()->teacherGuidePageZeroActivated->get().toBool())
+		return page != 0 && page < mCurrentDocument->pageCount() - 1;
+	else
+		return page < mCurrentDocument->pageCount() - 1;
+}
+
+bool UBDocumentController::pageCanBeDuplicated(int page)
+{
+	return page != 0;
+}
+
+bool UBDocumentController::pageCanBeDeleted(int page)
+{
+	return page != 0;
+}

src/document/UBDocumentController.h

@@ -51,6 +51,11 @@ class UBDocumentController : public QObject
         void deletePages(QList<QGraphicsItem*> itemsToDelete);
         int getSelectedItemIndex();
 
+        bool pageCanBeMovedUp(int page);
+        bool pageCanBeMovedDown(int page);
+        bool pageCanBeDuplicated(int page);
+        bool pageCanBeDeleted(int page);
+
     signals:
         void refreshThumbnails();
         void exportDone();

src/gui/UBThumbnailWidget.cpp

@@ -823,40 +823,22 @@ void UBSceneThumbnailNavigPixmap::mousePressEvent(QGraphicsSceneMouseEvent *even
 
 void UBSceneThumbnailNavigPixmap::updateButtonsState()
 {
-    bCanDelete = false;
+
+	bCanDelete = false;
     bCanMoveUp = false;
     bCanMoveDown = false;
-    bCanDuplicate = true;
+    bCanDuplicate = false;
-
+
-    UBDocumentProxy* p = proxy();
+    if(proxy()){
-    if(NULL != p && 0 <= UBApplication::boardController->pageFromSceneIndex(sceneIndex()))
+    	int pageIndex = UBApplication::boardController->pageFromSceneIndex(sceneIndex());
-    {
+    	UBDocumentController* documentController = UBApplication::documentController;
-        int iNbPages = p->pageCount();
+    	bCanDelete = documentController->pageCanBeDeleted(pageIndex);
-        if(1 < iNbPages)
+        bCanMoveUp = documentController->pageCanBeMovedUp(pageIndex);
-        {
+        bCanMoveDown = documentController->pageCanBeMovedDown(pageIndex);
-            bCanDelete = true;
+        bCanDuplicate = documentController->pageCanBeDuplicated(pageIndex);
-            if(sceneIndex() > 0)
-            {
-                bCanMoveUp = true;
-            }
-            if(sceneIndex() != iNbPages - 1)
-            {
-                bCanMoveDown = true;
-            }
-        }
     }
-    if(UBSettings::settings()->teacherGuidePageZeroActivated && sceneIndex()<=1)
-        bCanMoveUp = false;
-
-    if(UBSettings::settings()->teacherGuidePageZeroActivated && sceneIndex() == 0){
-    	bCanDelete = false;
-    	bCanDuplicate = false;
-    	bCanMoveUp = false;
-    	bCanMoveDown = false;
-    }
-
 
-    if(bCanDelete || bCanMoveUp || bCanMoveDown)
+    if(bCanDelete || bCanMoveUp || bCanMoveDown || bCanDuplicate)
         bButtonsVisible = true;
 }